Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add known_issues test for fs.copyFile() #26939

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/known_issues/known_issues.status
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,24 @@ prefix known_issues
[true] # This section applies to all platforms

[$system==win32]
test-fs-copyfile-respect-permissions: SKIP

[$system==linux]
test-vm-timeout-escape-promise: PASS,FLAKY
test-fs-copyfile-respect-permissions: SKIP

[$system==macos]

[$system==solaris]
test-fs-copyfile-respect-permissions: SKIP

[$system==freebsd]
test-fs-copyfile-respect-permissions: SKIP

[$system==aix]
test-fs-copyfile-respect-permissions: SKIP

[$arch==arm]
# https://github.com/nodejs/node/issues/24120
test-vm-timeout-escape-nexttick: PASS,FLAKY
test-fs-copyfile-respect-permissions: SKIP
50 changes: 50 additions & 0 deletions test/known_issues/test-fs-copyfile-respect-permissions.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
'use strict';

// Test that fs.copyFile() respects file permissions.
// Ref: https://github.com/nodejs/node/issues/26936

const common = require('../common');

const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

const assert = require('assert');
const fs = require('fs');
const path = require('path');

let n = 0;

function beforeEach() {
n++;
const source = path.join(tmpdir.path, `source${n}`);
const dest = path.join(tmpdir.path, `dest${n}`);
fs.writeFileSync(source, 'source');
fs.writeFileSync(dest, 'dest');
fs.chmodSync(dest, '444');

const check = (err) => {
assert.strictEqual(err.code, 'EACCESS');
assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'dest');
};

return { source, dest, check };
}

// Test synchronous API.
{
const { source, dest, check } = beforeEach();
assert.throws(() => { fs.copyFileSync(source, dest); }, check);
}

// Test promises API.
{
const { source, dest, check } = beforeEach();
assert.throws(async () => { await fs.promises.copyFile(source, dest); },
check);
}

// Test callback API.
{
const { source, dest, check } = beforeEach();
fs.copyFile(source, dest, common.mustCall(check));
}