Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: removing checking of non existent field in lib/inspector.js #27919

Closed
wants to merge 1 commit into from
Closed

inspector: removing checking of non existent field in lib/inspector.js #27919

wants to merge 1 commit into from

Conversation

Keroosha
Copy link
Contributor

Seems like sessionAttached doesn't exist and no more assigned anywhere

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@Keroosha
inspector: removing checking of non existent field in lib/inspector.js
19fc2cd 
Seems like sessionAttached doesn't exist and no more assigned anywhere
@nodejs-github-bot nodejs-github-bot added the inspector Issues and PRs related to the V8 inspector protocol label May 26, 2019
addaleax
addaleax approved these changes May 26, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @eugeneo

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23356/

eugeneo
eugeneo approved these changes May 26, 2019
View reviewed changes
Copy link
Contributor

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a left over from the dark times when only a single concurrent connection was allowed, no longer needed.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23371/

@BridgeAR BridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label May 29, 2019
@BridgeAR
Copy link
Member

@Keroosha thanks a lot for looking closely into this at the code & learn! Awesome job!

@ryzokuken
Copy link
Contributor

Landed in c91a90b 🎉

@ryzokuken ryzokuken closed this May 29, 2019
pull bot pushed a commit to SimenB/node that referenced this pull request May 29, 2019
@Keroosha @ryzokuken
inspector: removing checking of non existent field in lib/inspector.js
c91a90b 
Seems like sessionAttached doesn't exist and no more assigned anywhere

PR-URL: nodejs#27919
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request May 31, 2019
@Keroosha @targos
inspector: removing checking of non existent field in lib/inspector.js
512ab1f 
Seems like sessionAttached doesn't exist and no more assigned anywhere

PR-URL: #27919
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Eugene Ostroukhov <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Keroosha @nodejs-github-bot @BridgeAR @ryzokuken @eugeneo @Trott @addaleax @cjihrig