util: add guessHandleType method #2797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlucas
added
the
semver-minor
|
+1 to making it public, but I don't think |
|
I don't want to bloat util, but I think it makes more sense. |
With moving in the direction of deprecating process.binding, it makes sense to expose the ability to guess the handle type of an fd.
evanlucas
force-pushed
the
guesshandle
branch
from
b769dcd to
0edc7a5
Compare
evanlucas
changed the title
|
Ok, changed to util |
|
Has anyone actually asked for this? I know the debug module uses |
|
Not to my knowledge. Just wanted to take some proactive steps to when we actually deprecate |
|
Okay, in that case I'm -1 until a reasonable use case pops up. Adding an API is easy but if it turns out to be the wrong API, we're stuck with it. Proactivity is what got us the |
|
Fair enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With moving in the direction of deprecating process.binding,
it makes sense to expose the ability to guess the handle type
of an fd.
Does it make sense that this is exposed in
tty?An example of where this would be useful is debug which
is a quite popular package. (https://github.com/visionmedia/debug/blob/master/node.js#L144-L203)
Related: #2768