build: Warn when using snapshot on Armv6 #282
Conversation
|
I don't really like having two options "--without-snapshot" and "--force-snapshot". It seems more reasonable to either enable "--without-snapshot" by default on armv6. Or change the option to "--snapshot=on|off|auto". @bnoordhuis wdyt? |
|
Yeah i thought about that too. But i´d rather have the "--snapshot=on|off|auto" option so that |
|
I think I agree with Bert. In fact, I think I wouldn't change any configure switches but just print a big fat warning when someone leaves snapshots enabled on ARMv6. Being noisy about bugs gives people an incentive to go in and fix issue. Silently working around it accomplishes pretty much the opposite. |
|
Ok now it will just print a warning at the end of the configure script. |
|
lgtm, please squash your commits @Cydox and make them conform to the contributing guidelines in CONTRIBUTING.md. |
Building io.js on armv6 with snapshot enabled does not work due to a bug in v8, so it now warns when building on armv6 and having snapshot enabled. I found this problem while trying to build io.js on my Raspberry Pi. With snapshot disabled v8 and all of the code compiles , but still when testing io.js I get an 'illegal instruction' error. I´ll open an issue for that.
|
OK, i squashed the commits and changed the commit message. |
Cydox
changed the title
|
I changed the title to fit your guideline. |
Building io.js on armv6 with snapshot enabled does not work due to a bug in v8, so it now warns when building on armv6 and having snapshot enabled. PR-URL: #282 Reviewed-By: Rod Vagg <[email protected]>
|
@Cydox Got a reference to that snapshot bug in v8? |
Building io.js on armv6 with snapshot enabled does not work due to a bug in v8, so it now is disabled by default when building on armv6.
However I added a --force-snapshot option so the user can enable snapshot for debuging purposes.
I found this problem while trying to build io.js on my Raspberry Pi. With snapshot disabled v8 and all of the code compiles
, but still when testing io.js I get an 'illegal instruction' error. I´ll open an issue for that.