Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "http: simplify drain()" #29244

Closed
wants to merge 1 commit into from
Closed

Revert "http: simplify drain()" #29244

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 21, 2019

This reverts commit bdf07f4.

The commit causes somewhat rampant MaxListenerExceeded warnings on
fairly generic npm installs.

Fixes: #29239

Collaborators: 👍 here to fast-track

@mcollina @targos

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
Revert "http: simplify drain()"
cefd461 
This reverts commit bdf07f4.

The commit causes somewhat rampant MaxListenerExceeded warnings on
fairly generic npm installs.

Fixes: nodejs#29239
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 21, 2019
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 21, 2019
@Trott Trott mentioned this pull request Aug 21, 2019
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25142/

mcollina
mcollina approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member

targos commented Aug 21, 2019

LGTM but I'm not available to prepare a release today

@ronag ronag mentioned this pull request Aug 21, 2019
Closed
4 tasks
@ronag
Copy link
Member

ronag commented Aug 21, 2019

Alternative fix if desired #29245.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25146/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25156/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25159/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25185/

@Trott
Copy link
Member Author

Trott commented Aug 23, 2019

Talked offline with @jasnell who felt that #29245 was preferable, so I'll close this. Feel free to re-open (or easy enough to do another revert PR separate from this) if #29245 stalls or otherwise doesn't work out.

@Trott Trott closed this Aug 23, 2019
@Trott Trott deleted the revert-for-12.9.1 branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@silverwind silverwind silverwind approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

12.9.0 MaxListenersExceededWarning
8 participants
@Trott @nodejs-github-bot @targos @ronag @mcollina @silverwind @cjihrig @trivikr