Revert "url: support path for url.format"
#303
Merged
+9
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe I should just leave that out, the fix-up was for another commit. |
|
Unfortunately, lgtm. @bnoordhuis is the path forward with this to bring the feature back in and try and fix the underlying problem post 1.0.0? Can we give some guidance to @yorkie? |
This reverts commit d312b6d. Reverted for breaking `npm install` with git+ssh URLs. Conflicts: doc/api/url.markdown Fixes: nodejs#295 PR-URL: nodejs#303 Reviewed-By: Rod Vagg <[email protected]>
bnoordhuis
force-pushed
the
revert-d312b6d
branch
from
094e91d to
913addb
Compare
|
I think the guidance should be that |
|
Got it, thank you @rvagg @bnoordhuis i will try to add this feature again but with test covering the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d312b6d.
Reverted for breaking
npm installwith git+ssh URLs.See also the fix-up in commit a1e54d6.
Conflicts:
doc/api/url.markdown
Fixes: #295
R=@evanlucas or @rvagg, /cc @yorkie