test: add tls early data (0-RTT) regression test #31811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
force-pushed
the
tls-early-data-test
branch
from
ba512a5 to
352c647
Compare
bnoordhuis
changed the title
cjihrig
approved these changes
Feb 15, 2020
jasnell
reviewed
Feb 17, 2020
| @@ -0,0 +1,77 @@ | |||
| 'use strict'; | |||
| const common = require('../common'); | |||
|
|
|||
There was a problem hiding this comment.
A comment briefly explaining the intent of the test would be good here.
This way we'll know if and when the behavior changes. Right now, early data should not be sent because Node's built-in TLS server doesn't support it. Refs: nodejs#31802 (comment)
bnoordhuis
force-pushed
the
tls-early-data-test
branch
from
352c647 to
fda0070
Compare
|
I'm abandoning this PR. The test has wildly different behavior across machines, for no good reason that I can see, and I don't feel like sinking hours into debugging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we'll know if and when the behavior changes. Right now, early
data should not be sent because Node's built-in TLS server doesn't
support it.
Refs: #31802 (comment)