Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add coverage for FSWatcher exception #32057

Closed
wants to merge 0 commits into from
Closed

test: add coverage for FSWatcher exception #32057

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 3, 2020

Cover an previously uncovered exception possible in the internal start
function for FSWatcher.

While at it, remove convenience function for internal assertions from testing common module. It is only used once.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 3, 2020
@Trott Trott mentioned this pull request Mar 3, 2020
Closed
4 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29511/

@Trott
Copy link
Member Author

Trott commented Mar 3, 2020

@nodejs/testing

@Trott
Copy link
Member Author

Trott commented Mar 4, 2020

@nodejs/fs

@Trott
Copy link
Member Author

Trott commented Mar 4, 2020

This could use a review or two. @nodejs/collaborators

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2020
Trott added a commit to Trott/io.js that referenced this pull request Mar 5, 2020
@Trott
test: remove common.expectsInternalAssertion
616a729 
Remove convenience function for internal assertions. It is only used
once.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: nodejs#32057
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Mar 5, 2020
@Trott
test: add coverage for FSWatcher exception
b1d4c13 
Cover an previously uncovered exception possible in the internal start
function for FSWatcher.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: nodejs#32057
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@Trott Trott closed this Mar 5, 2020
@Trott Trott force-pushed the common-int-assert branch from c175ff1 to b1d4c13 Compare March 5, 2020 15:10
@Trott
Copy link
Member Author

Trott commented Mar 5, 2020

Landed in 757e203...b1d4c13

@Trott Trott deleted the common-int-assert branch March 5, 2020 15:10
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@Trott @MylesBorins
test: remove common.expectsInternalAssertion
89987b3 
Remove convenience function for internal assertions. It is only used
once.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32057
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@Trott @MylesBorins
test: add coverage for FSWatcher exception
83e9a3e 
Cover an previously uncovered exception possible in the internal start
function for FSWatcher.

Signed-off-by: Rich Trott <[email protected]>

PR-URL: #32057
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Merged
@codebytere
Copy link
Member

@Trott is this applicable to v12.x? It looks like common is still used several places in the file that was refactored so it might not be. I'll set the dont-land label for now but feel free to update it or open a manual backport if you do feel it should go back!

@Trott
Copy link
Member Author

Trott commented Mar 16, 2020

I'll set the dont-land label for now but feel free to update it or open a manual backport if you do feel it should go back!

This just adds some test coverage and is inessential, so I think dont-land should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@antsmartian antsmartian antsmartian approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @codebytere @antsmartian @lpinca