Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: edit filehandle.close() entry in fs.md #34782

Closed
wants to merge 1 commit into from
Closed

doc: edit filehandle.close() entry in fs.md #34782

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 14, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Aug 14, 2020
@jasnell
Copy link
Member

jasnell commented Aug 17, 2020

Landed in c62cf1d

@jasnell jasnell closed this Aug 17, 2020
jasnell pushed a commit that referenced this pull request Aug 17, 2020
@Trott @jasnell
doc: edit filehandle.close() entry in fs.md
c62cf1d 
PR-URL: #34782
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@Trott @MylesBorins
doc: edit filehandle.close() entry in fs.md
3ca33a9 
PR-URL: #34782
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@Trott @BethGriggs
doc: edit filehandle.close() entry in fs.md
258f64f 
PR-URL: #34782
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@Trott Trott deleted the filehandleclose branch April 14, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @jasnell @tniessen @richardlau @BridgeAR @HarshithaKP @nodejs-github-bot