test: remove setMaxListeners in test-crypto-random #35079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
crypto
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Sep 6, 2020
lpinca
approved these changes
Sep 7, 2020
Trott
approved these changes
Sep 7, 2020
This appears to be a remnant from 413d38c. PR-URL: nodejs#35079 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trott
force-pushed
the
test-remove-setmaxlisteners
branch
from
ccd36da to
f07f420
Compare
|
Landed in f07f420 |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2020
This appears to be a remnant from 413d38c. PR-URL: #35079 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
This appears to be a remnant from 413d38c. PR-URL: #35079 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
This appears to be a remnant from 413d38c. PR-URL: nodejs#35079 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be a remnant from 413d38c. Since
common.mustCallnever registers more than one listener, it is unnecessary.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes