wip make policies not apply to the wrapper #36472
Closed
+84
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so policies don't have to apply to the wrapper for things like STDIN or --eval.
Currently this does keep the URL for the check at
file:///...[eval]
etc. Likely we should differentiate this on the policy rather than having it collide with a file on disk. I was thinking something likeapp:{[eval],[stdin]}
. However, this does have a problem that the wrapper module path would differ from the policy. I'm open to any sort of disambiguation or punting that for now even.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes