Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 7.12.0 #38584

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.12.0 #38584

wants to merge 1 commit into from

Conversation

darcyclarke
Copy link
Member

v7.12.0 (2021-05-06)

FEATURES

BUG FIXES

DEPENDENCIES

@github-actions github-actions bot added needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels May 7, 2021
@lpinca
Copy link
Member

lpinca commented May 7, 2021

Can you please remove the merge commit?

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@darcyclarke
Copy link
Member Author

fast-track / dont-land-on-v12.x / dont-land-on-v14.x ?

@lpinca lpinca added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. labels May 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

Fast-track has been requested by @lpinca. Please 👍 to approve.

Trott
Trott approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37994/

@ruyadorno
Copy link
Member

closing in favor of #38628

@ruyadorno ruyadorno closed this May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@darcyclarke @lpinca @nodejs-github-bot @ruyadorno @Trott @addaleax @cjihrig