Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: compose with async functions #39435

Closed
wants to merge 3 commits into from
Closed

stream: compose with async functions #39435

wants to merge 3 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 19, 2021

Enables async function support for stream.compose.

@ronag
stream: compose with async functions
f8e9aac 
Enables async function support for stream.compose.
@ronag ronag added the stream Issues and PRs related to the stream subsystem. label Jul 19, 2021
@ronag ronag requested a review from benjamingr July 19, 2021 06:20
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 19, 2021
@ronag
Copy link
Member Author

ronag commented Jul 19, 2021 •
edited
Loading

We disabled async function in the compose PR due to @benjamingr request to review the async fn API before landing.

VoltrexKeyva
VoltrexKeyva reviewed Jul 19, 2021
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
VoltrexKeyva
VoltrexKeyva reviewed Jul 19, 2021
View reviewed changes
doc/api/stream.md Outdated Show resolved Hide resolved
ronag and others added 2 commits July 19, 2021 12:09
@ronag
Copy link
Member Author

ronag commented Jul 19, 2021

@nodejs/streams

@jasnell
Copy link
Member

jasnell commented Jul 19, 2021

Changes look good but does this need additional tests?

@ronag
Copy link
Member Author

ronag commented Jul 19, 2021

Changes look good but does this need additional tests?

The tests are already merged through the original PR.

mcollina
mcollina approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39160/

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jul 20, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39196/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39200/

@ronag
Copy link
Member Author

ronag commented Jul 21, 2021

Landed in 48ff0a1

@ronag ronag closed this Jul 21, 2021
ronag added a commit that referenced this pull request Jul 21, 2021
@ronag
stream: compose with async functions
48ff0a1 
Enables async function support for stream.compose.

PR-URL: #39435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos
Copy link
Member

targos commented Jul 21, 2021

Depends on #39029

ronag added a commit to nxtedition/node that referenced this pull request Jul 28, 2021
@ronag
stream: compose with async functions
5ae2416 
Enables async function support for stream.compose.

PR-URL: nodejs#39435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ronag
Copy link
Member Author

ronag commented Jul 28, 2021

#39563

ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2021
@ronag
stream: compose with async functions
44744d9 
Enables async function support for stream.compose.

PR-URL: nodejs#39435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2021
@ronag
stream: compose with async functions
6d54abe 
Enables async function support for stream.compose.

PR-URL: nodejs#39435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Aug 1, 2021
@ronag
stream: compose with async functions
36dbe25 
Enables async function support for stream.compose.

PR-URL: nodejs#39435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Aug 1, 2021
@ronag
stream: compose with async functions
890d25f 
Enables async function support for stream.compose.

PR-URL: nodejs#39435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Aug 1, 2021
@ronag
stream: compose with async functions
1726283 
Enables async function support for stream.compose.

PR-URL: nodejs#39435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2021
@ronag
stream: compose with async functions
bc2d69d 
Enables async function support for stream.compose.

PR-URL: nodejs#39435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
ronag added a commit to nxtedition/node that referenced this pull request Aug 23, 2021
@ronag
stream: compose with async functions
81187c2 
Enables async function support for stream.compose.

PR-URL: nodejs#39435
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ronag @jasnell @nodejs-github-bot @targos @mcollina @benjamingr @VoltrexKeyva