src: add kNoBrowserGlobals flag for Environment #40356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
joyeecheung
requested changes
Oct 7, 2021
There was a problem hiding this comment.
This should be done via the internal options infra so that it doesn't bypass the snapshot building checks - instead of skipping the installation of the browser globals during bootstrapping (which is meant to be stateless), we should remove them in pre-execution.
|
I created #40357 to move the embedder options to the runtime part of the bootstrap |
|
Thanks for looking into this, I'll create a new PR after #40357 gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the runtime equivalent of the
configure --no-browser-globalsbuild flag.A runtime flag is needed because embedders may support multiple modes of Node.js that, Node.js may both run in a browser environment, and in an independent environment that has no browser globals. For example, Node.js script running in web page spawning a script with
child_process.fork./cc @nodejs/embedders