lib: expose undici's ProxyAgent as global object
#46405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Thank you for the contribution @AngeloCore, unfortunately I believe the discussion around #43187 did not lead to the outcome that exposing an Undici-specific global is the solution, cc @mcollina. |
|
It didn't. We agreed to make undici aware of the proxy env variables. |
mcollina
requested changes
Jan 29, 2023
|
Okay |
|
I want to set a different proxy for each request, only ProxyAgent is flexible enough to do this. ProxyAgent should be exposed globally, or provide a way to access it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #43187 (not completely)
Why
Currently, to use the
fetchmethod usingProxyAgent, you need to download the entire undici library.This is my first contribution to a super-large project, if I did a mistake, please correct me in the comments.