[v20.x backport] backport: esm: require braces for modules code #50268
Conversation
|
Review requested:
|
nodejs-github-bot
added
lib / src
PR-URL: nodejs#49657 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
GeoffreyBooth
force-pushed
the
backport-49657-to-20
branch
from
fc934ad to
83e582a
Compare
GeoffreyBooth
changed the title
GeoffreyBooth
removed
the
lib / src
GeoffreyBooth
changed the title
| { | ||
| files: [ | ||
| 'lib/internal/modules/**/*.js', | ||
| ], | ||
| rules: { | ||
| 'curly': 'error', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Can you remove this to avoid getting error when backporting commits that landed before this rule was introduced?
There was a problem hiding this comment.
If there are commits to backport from before this rule, I highly recommend to backport them first.
There was a problem hiding this comment.
I don't know if they actually are any, regardless having less strict lint rules on LTS lines seems like a good idea to me, but it's just a nit
There was a problem hiding this comment.
So I looked into this, and the only two commits from before this rule are:
- src: throw DataCloneError on transfering untransferable objects #47604, which is semver-major so we won’t backport it.
- esm: remove
globalPreloadhook (superseded byinitialize) #49144, which @aduh95 requested not be backported. It also wouldn’t run afoul of this rule regardless, because it’s almost all deletions and the few additions include the newly required braces.
So I think the rule is fine to backport, and I’d rather not create unnecessary divergences from main. This rule is also very easy to abide by, and the linter can fix for it automatically.
|
Landed in 0103979 |
PR-URL: #49657 Backport-PR-URL: #50268 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Jacob Smith <[email protected]>
This backports:
Resolves #49657 (comment).