test: migrate message eval tests from Python to JS

[yiyunlei]

Migrate the eval tests in the test/message folder from Python to JS.

[MoLow]

can you please take a look into failing tests?

[yiyunlei]

can you please take a look into failing tests?

Sure.

[marco-ippolito]

@yiyunlei may I take over the pr? This would unblock my pr 💚 #56285 (comment)

[yiyunlei]

@yiyunlei may I take over the pr? This would unblock my pr 💚 #56285 (comment)

Sure, no problem.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64174/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (eb1cb36) to head (965ba46).
Report is 224 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #50482      +/-   ##
==========================================
+ Coverage   88.01%   88.53%   +0.52%     
==========================================
  Files         653      657       +4     
  Lines      187728   190395    +2667     
  Branches    35868    36545     +677     
==========================================
+ Hits       165225   168570    +3345     
+ Misses      15693    14999     -694     
- Partials     6810     6826      +16     

see 157 files with indirect coverage changes

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64178/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64180/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64181/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/50482
✔  Done loading data for nodejs/node/pull/50482
----------------------------------- PR info ------------------------------------
Title      test: migrate message eval tests from Python to JS (#50482)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     yiyunlei:migrate-eval-tests -> nodejs:main
Labels     test, author ready, needs-ci, review wanted
Commits    2
 - test: migrate message eval tests from Python to JS
 - fixup
Committers 1
 - Marco Ippolito <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/50482
Reviewed-By: Juan José Arboleda <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50482
Reviewed-By: Juan José Arboleda <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 31 Oct 2023 05:12:51 GMT
   ✔  Approvals: 1
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/50482#pullrequestreview-2521162545
   ⚠  GitHub cannot link the author of 'test: migrate message eval tests from Python to JS' to their GitHub account.
   ⚠  Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-12-23T19:59:06Z: https://ci.nodejs.org/job/node-test-pull-request/64181/
- Querying data for job/node-test-pull-request/64181/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 50482
From https://github.com/nodejs/node
 * branch                  refs/pull/50482/merge -> FETCH_HEAD
✔  Fetched commits as 56d58654ed60..8d17393258f3
--------------------------------------------------------------------------------
[main 911f4bc792] test: migrate message eval tests from Python to JS
 Author: Yiyun Lei <[email protected]>
 Date: Tue Oct 31 01:08:25 2023 -0400
 5 files changed, 59 insertions(+), 26 deletions(-)
 rename test/{message => fixtures/eval}/eval_messages.js (98%)
 rename test/{message/eval_messages.out => fixtures/eval/eval_messages.snapshot} (72%)
 rename test/{message => fixtures/eval}/stdin_messages.js (98%)
 rename test/{message/stdin_messages.out => fixtures/eval/stdin_messages.snapshot} (72%)
 create mode 100644 test/parallel/test-node-output-eval.mjs
[main 8aa7d011fe] fixup
 Author: Marco Ippolito <[email protected]>
 Date: Mon Dec 23 17:31:23 2024 +0100
 3 files changed, 72 insertions(+), 72 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: migrate message eval tests from Python to JS
Migrate the eval tests in the test/message folder from Python to JS.
PR-URL: #50482

Reviewed-By: Juan José Arboleda <[email protected]>
[detached HEAD 407439d62b] test: migrate message eval tests from Python to JS

Author: Yiyun Lei <[email protected]>

Date: Tue Oct 31 01:08:25 2023 -0400

5 files changed, 59 insertions(+), 26 deletions(-)

rename test/{message => fixtures/eval}/eval_messages.js (98%)

rename test/{message/eval_messages.out => fixtures/eval/eval_messages.snapshot} (72%)

rename test/{message => fixtures/eval}/stdin_messages.js (98%)

rename test/{message/stdin_messages.out => fixtures/eval/stdin_messages.snapshot} (72%)

create mode 100644 test/parallel/test-node-output-eval.mjs

Rebasing (3/4)

Rebasing (4/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fixup
PR-URL: #50482

Reviewed-By: Juan José Arboleda <[email protected]>
[detached HEAD a29c5cfee2] fixup

Author: Marco Ippolito <[email protected]>

Date: Mon Dec 23 17:31:23 2024 +0100

3 files changed, 72 insertions(+), 72 deletions(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/12473287213

[marco-ippolito]

@yiyunlei apparently the automation cannot link the commit back to you, I think due to the email

[marco-ippolito]

I jsut amended the author, the last CI was green CI: https://ci.nodejs.org/job/node-test-pull-request/64181/

[marco-ippolito]

Landed in a9e65f6