build: remove patch for Android build
#51660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeowShe
force-pushed
the
android-fixes
branch
from
acbd09f to
d566969
Compare
MeowShe
force-pushed
the
android-fixes
branch
from
d566969 to
fb2f546
Compare
|
CC @richardlau |
|
Wouldn't it be better to keep the patch support in |
I understand your point, however, the patch was initially intended as a compromise, and all issues that arise should be addressed at their source, rather than being temporarily mitigated through patches. But again, I think it's going to take some time to transition, so let's keep the patch for now, and thank you for your input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to
src/trap-handler/trap-handler.his no longer needed now in Android building.Tested on Docker with image
ubuntu:latestwith eca4b1a (HEAD),android-ndk-r26b-linux.Related to PR #51632, as part of a series of build fixes for Android.