Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: throw error when pass overlapped to spawn_sync #52352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: throw error when pass overlapped to spawn_sync #52352

wants to merge 1 commit into from

Conversation

theanarkh
Copy link
Contributor

overlapped is not supported in *Sync API of child_process module currently.
fix: #52265

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Apr 3, 2024
@theanarkh theanarkh added the review wanted PRs that need reviews. label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow left review comments

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process crashes when using child_process.spawnSync(..., {stdio: ['pipe', 'overlapped', 'pipe']})
3 participants
@theanarkh @MoLow @nodejs-github-bot