Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update codecov #53891

Closed
wants to merge 3 commits into from
Closed

build: update codecov #53891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98d5018
build: update codecov coverage build count
anonrig Jul 17, 2024
2c1be15
build: enable codecov comments
anonrig Jul 17, 2024
0d78664
build: trigger coverage ci when updating codecov
anonrig Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/coverage-linux-without-intl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ on:
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-linux-without-intl.yml
- codecov.yml
push:
branches:
- main
Expand All @@ -24,6 +25,7 @@ on:
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-linux-without-intl.yml
- codecov.yml

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/coverage-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ on:
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-linux.yml
- codecov.yml
push:
branches:
- main
Expand All @@ -24,6 +25,7 @@ on:
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-linux.yml
- codecov.yml

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/coverage-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ on:
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-windows.yml
- codecov.yml
push:
branches:
- main
Expand All @@ -24,6 +25,7 @@ on:
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-windows.yml
- codecov.yml

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down
19 changes: 10 additions & 9 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
# TODO(bcoe): re-enable coverage report comments, once we can figure out
# how to make them more accurate for the Node.js project,
# See: https://github.com/nodejs/node/issues/35759
comment: false
# # Only show diff and files changed:
# layout: "diff, files"
# # Don't post if no changes in coverage:
# require_changes: true
comment:
# Only show diff and files changed:
layout: diff, files
# Don't post if no changes in coverage:
require_changes: true

codecov:
branch: main
notify:
# Wait for all coverage builds:
after_n_builds: 2
# - coverage-linux.yml
# - coverage-windows.yml
# - coverage-linux-without-intl.yml
after_n_builds: 3

coverage:
# Useful for blocking Pull Requests that don't meet a particular coverage threshold.
status:
project: off
patch: off
Loading