tools: add test/addons/0* to .eslintignore #5425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
force-pushed
the
ignore-generated-addons
branch
from
5c71572 to
40451d2
Compare
Closed
| @@ -1,7 +1,6 @@ | |||
| lib/internal/v8_prof_polyfill.js | |||
There was a problem hiding this comment.
These files are copied directly from the v8 source, no? If so, we probably don't want to apply our coding style standards to their code?
There was a problem hiding this comment.
rebase gone wrong
MylesBorins
force-pushed
the
ignore-generated-addons
branch
from
40451d2 to
9545d84
Compare
The scripts generated by `make test-addons` do not pass the linter. For now I think it is best that we ignore it as they are not tracked in the tree. Temporary Workaround for nodejs#5424 PR-URL: nodejs#5425
MylesBorins
force-pushed
the
ignore-generated-addons
branch
from
9545d84 to
1242d60
Compare
|
LGTM |
mscdex
added
c++
|
Alternative (or subsequent, but we'll have to add in something to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scripts generated by
make test-addonsdo not pass the linter.For now I think it is best that we ignore it as they are not tracked in the tree.
Fixes #5424