tty: expose hasColors and getColorDepth
#54415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes `hasColors` and `getColorDepth` under `tty`. Documentation-only deprecates `tty.WriteStream.prototype.getColorDepth` and `tty.WriteStream.prototype.hasColors`. Co-Authored-By: Yaksh Bariya <[email protected]>
nodejs-github-bot
added
needs-ci
avivkeller
added
notable-change
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
|
CC @nodejs/tty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the direct exposure of
hasColorsandgetColorDepthunder thettymodule. In addition, it documentation-deprecates their previous locations.This work builds on #40240, an older draft that has been inactive for several years. Given the interest in that original PR, I decided to complete it and submit this one.
Fixes #40236.