buffer: don't use Fast API for utf8 #54525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
buffer
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 23, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 Refs: nodejs#54525
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
|
Would be nice if we could have a fast implementation that does the same as |
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 23, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 23, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 23, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
|
#54526 Seems like a better option. |
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 23, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 23, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54525 +/- ##
==========================================
- Coverage 87.33% 87.32% -0.01%
==========================================
Files 649 649
Lines 182561 182559 -2
Branches 35041 35040 -1
==========================================
- Hits 159444 159424 -20
- Misses 16378 16394 +16
- Partials 6739 6741 +2
|
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 23, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 24, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 24, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 27, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 28, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 28, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 29, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 30, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 30, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Aug 31, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Sep 2, 2024
Fast API handles invalid UTF differently than the slow API. Fixes: nodejs#54521 PR-URL: nodejs#54525
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Sep 2, 2024
Re-enables fast Fast API for Buffer.write after fixing UTF8 handling. Fixes: nodejs#54521 PR-URL: nodejs#54525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast API handles invalid UTF differently than the slow API.
Fixes: #54521