Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update eslint to v2.2.0 #5457

Closed
wants to merge 1 commit into from
Closed

tools: update eslint to v2.2.0 #5457

wants to merge 1 commit into from

Conversation

dnalborczyk
Copy link
Contributor

update eslint from v2.1.0 to v2.2.0 for new features and bug fixes

blog:
http://eslint.org/blog/2016/02/eslint-v2.2.0-released

changelog:
https://github.com/eslint/eslint/blob/master/CHANGELOG.md

@mscdex mscdex added the tools Issues and PRs related to the tools directory. label Feb 26, 2016
@rvagg
Copy link
Member

rvagg commented Feb 27, 2016

perhaps we can wait for the next release? not so great that the test suite is broken eslint/eslint#5415

@silverwind
Copy link
Contributor

Yes, I think we're better off waiting. There's not much to get excited about in 2.2.0.

@silverwind
Copy link
Contributor

@dnalborczyk thanks for the contribution, but I don't think we can take it for above reasons. If 2.3.0 proves to be of value to us, we can check that out.

Note that we take a few extra steps when updating ESLint, outlined here (We should document these better).

@silverwind silverwind closed this Feb 29, 2016
@dnalborczyk
Copy link
Contributor Author

No problem. Though I wasn't aware of this, I did follow pretty much the same procedure:

delete tools/eslint
npm install eslint --production (which leaves out dev dependencies)
copy eslint from node_modules to tools, copy (remaining) node_modules folder.

Daniel

@silverwind
Copy link
Contributor

Yeah, I was mostly pointing out dnm to remove more unneccessary files :)

@dnalborczyk
Copy link
Contributor Author

Ah, I see, I missed that. Thanks for pointing that out, much appreciated! I didn't know such a tool existed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants