src: move more key handling to ncrypto #55108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
This comment was marked as outdated.
This comment was marked as outdated.
avivkeller
added
crypto
anonrig
reviewed
Sep 24, 2024
jasnell
force-pushed
the
moar-evp-key-to-ncrypto
branch
from
7bdbb3b to
a886db5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Sep 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55108 +/- ##
==========================================
- Coverage 88.25% 88.25% -0.01%
==========================================
Files 651 651
Lines 183900 183818 -82
Branches 35860 35834 -26
==========================================
- Hits 162296 162222 -74
- Misses 14894 14905 +11
+ Partials 6710 6691 -19
|
jasnell
force-pushed
the
moar-evp-key-to-ncrypto
branch
from
a886db5 to
23802fb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Sep 24, 2024
aduh95
added
the
dont-land-on-v20.x
jasnell
force-pushed
the
moar-evp-key-to-ncrypto
branch
from
23802fb to
c23255d
Compare
jasnell
force-pushed
the
moar-evp-key-to-ncrypto
branch
from
c23255d to
4ef5c9e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Sep 28, 2024
jasnell
added
the
author ready
KhafraDev
approved these changes
Sep 28, 2024
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ac53a5b |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55108 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55108 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55108 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55108 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matthew Aitken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More incremental moving of evp key handlnig to ncrypto