Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update nghttp3 to 1.6.0 #55976

Closed
wants to merge 1 commit into from
Closed

deps: update nghttp3 to 1.6.0 #55976

wants to merge 1 commit into from
+6,768 −8,227

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of nghttp3 to 1.6.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Nov 24, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Nov 24, 2024
@targos
Copy link
Member

targos commented Nov 24, 2024 

 ../deps/ngtcp2/nghttp3/lib/nghttp3_http.c:39:10: fatal error: 'sfparse/sfparse.h' file not found
   39 | #include "sfparse/sfparse.h"
      |          ^~~~~~~~~~~~~~~~~~~
1 error generated.

We can see in the diff that sfparse.h and sfparse.c are removed, but they are still upstream: https://github.com/ngtcp2/nghttp3/tree/v1.6.0/lib

@richardlau
Copy link
Member

#51321 (comment)

sfparse is now a git submodule in upstream nghttp3: ngtcp2/nghttp3@e755bfb

@aduh95
Copy link
Contributor

aduh95 commented Nov 27, 2024

I’ve opened #56007 to address the issue.

@aduh95 aduh95 closed this Dec 15, 2024
@aduh95 aduh95 deleted the actions/tools-update-nghttp3 branch December 15, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nodejs-github-bot @targos @richardlau @aduh95