-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspector: report loadingFinished until the response data is consumed #56372
Merged
+412
−299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
inspector
Issues and PRs related to the V8 inspector protocol
needs-ci
PRs that need a full CI run.
labels
Dec 26, 2024
legendecas
force-pushed
the
inspector/undici
branch
2 times, most recently
from
December 26, 2024 23:51
8980bb1
to
1dec91e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56372 +/- ##
==========================================
- Coverage 88.55% 88.54% -0.01%
==========================================
Files 657 659 +2
Lines 190658 190817 +159
Branches 36589 36617 +28
==========================================
+ Hits 168837 168966 +129
- Misses 15009 15033 +24
- Partials 6812 6818 +6
|
jasnell
approved these changes
Dec 28, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 28, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The `Network.loadingFinished` should be deferred until the response is complete and the data is fully consumed. Also, report correct request url with the specified port by retrieving the host from the request headers.
legendecas
force-pushed
the
inspector/undici
branch
from
January 2, 2025 17:16
1dec91e
to
031ee3a
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 2, 2025
cola119
approved these changes
Jan 5, 2025
cola119
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
needs-ci
PRs that need a full CI run.
labels
Jan 5, 2025
legendecas
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 5, 2025
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jan 5, 2025
Landed in 9400eae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
inspector
Issues and PRs related to the V8 inspector protocol
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Network.loadingFinished
should be deferred until the response iscomplete and the data is fully consumed. Also, report correct request
url with the specified port by retrieving the host from the request
headers. The
timestamp
in the network events should be monotonictimes.
Refs: #53946