Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for known issue with event emitters #5649

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 10, 2016

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

test, events

Description of change

Add test for known issue where a valid event name may be rejected.

Refs: #728

@Trott Trott added events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests. lts-watch-v4.x labels Mar 10, 2016
@mscdex mscdex mentioned this pull request Mar 11, 2016
4 tasks
@jasnell
Copy link
Member

jasnell commented Mar 11, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Mar 12, 2016

Closing, with permission, in favor of 10bc673

@cjihrig cjihrig closed this Mar 12, 2016
@Trott Trott deleted the proto-noto branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants