src: move more crypto to ncrypto #56653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
jasnell
force-pushed
the
jasnell/ncrypto-big-push
branch
3 times, most recently
from
a6bff3a to
ac499cb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Jan 19, 2025
mertcanaltin
approved these changes
Jan 19, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/ncrypto-big-push
branch
from
ac499cb to
2e01641
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
|
There are relevant test failures to investigate.... |
jasnell
force-pushed
the
jasnell/ncrypto-big-push
branch
2 times, most recently
from
2c331fe to
fb45936
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/ncrypto-big-push
branch
from
fb45936 to
7c4b4e1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/ncrypto-big-push
branch
from
7c4b4e1 to
b296a6e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/ncrypto-big-push
branch
from
b296a6e to
649a07a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
jasnell/ncrypto-big-push
branch
from
649a07a to
51c7250
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
9 flaky CI runs and counting.... :-/ @nodejs/testing |
jasnell
added
commit-queue-squash
jasnell
added a commit
that referenced
this pull request
Jan 26, 2025
PR-URL: #56653 Reviewed-By: Yagiz Nizipli <[email protected]>
|
Landed in e0a7151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even more ncrypto conversion... nearly done with the initial push.. likely one more PR until we'll be ready to move ncrypto off into it's own repo.