util: enforce shouldColorize in styleText array arg #56722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56722 +/- ##
==========================================
- Coverage 89.22% 89.21% -0.01%
==========================================
Files 663 663
Lines 191974 191963 -11
Branches 36926 36923 -3
==========================================
- Hits 171286 171269 -17
- Misses 13561 13565 +4
- Partials 7127 7129 +2
|
jasnell
approved these changes
Jan 23, 2025
marco-ippolito
added
author ready
github-actions
bot
removed
the
request-ci
fisker
reviewed
Jan 24, 2025
fisker
reviewed
Jan 24, 2025
marco-ippolito
force-pushed
the
fix-color-style-trxt
branch
3 times, most recently
from
4599cad to
d4b5727
Compare
deokjinkim
reviewed
Jan 26, 2025
deokjinkim
approved these changes
Jan 26, 2025
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
marco-ippolito
force-pushed
the
fix-color-style-trxt
branch
from
d4b5727 to
0477278
Compare
marco-ippolito
added
the
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
targos
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56722 ✔ Done loading data for nodejs/node/pull/56722 ----------------------------------- PR info ------------------------------------ Title util: enforce shouldColorize in styleText array arg (#56722) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch marco-ippolito:fix-color-style-trxt -> nodejs:main Labels util, author ready, needs-ci Commits 1 - util: enforce shouldColorize in styleText array arg Committers 1 - Marco Ippolito <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56722 Fixes: https://github.com/nodejs/node/issues/56717 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56722 Fixes: https://github.com/nodejs/node/issues/56717 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - util: enforce shouldColorize in styleText array arg ℹ This PR was created on Thu, 23 Jan 2025 09:47:01 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56722#pullrequestreview-2570227033 ✔ - Deokjin Kim (@deokjinkim): https://github.com/nodejs/node/pull/56722#pullrequestreview-2574199082 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-01-28T15:57:43Z: https://ci.nodejs.org/job/node-test-pull-request/64805/ - Querying data for job/node-test-pull-request/64805/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13028022647 |
targos
approved these changes
Jan 29, 2025
targos
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f4fba08 |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2025
PR-URL: #56722 Fixes: #56717 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Deokjin Kim <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #56717