Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: adding #include <cstdint> to worker_inspector. h for gcc v15 #56740

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

tjuhaszrh
Copy link
Contributor

@tjuhaszrh tjuhaszrh commented Jan 24, 2025

Added cstdint to worker_inspector.h as on new version of gcc
(v15) the build was failing due to changes to libstdc++ and
the removal of transitive includes. Build then now fails due to
the usage of uint64_t in worker_inspector.h.
Output of build:
`../../src/inspector/worker_inspector.h:63:7: error: ‘uint64_t’ has not been declared
63 | uint64_t thread_id, const std::string& url, const std::string& name) {
| ^~~~~~~~

../../src/inspector/worker_inspector.h:12:1: note: ‘uint64_t’ is defined in header ‘’; this is probably fixable by adding ‘#include ’
11 | #include <unordered_set>
+++ |+#include `

Fixes: #56731

Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes

Fixes: nodejs#56731
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 24, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. lts-watch-v20.x PRs that may need to be released in v20.x labels Jan 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 24, 2025
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 24, 2025
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@legendecas
Copy link
Member

Would you mind updating the commit message to address the linter complaints?

  • First word after subsystem(s) in title should be lowercase
  • Fixes must be a URL, not an issue number

Thanks!

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.22%. Comparing base (08eeddf) to head (a6eedd7).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56740   +/-   ##
=======================================
  Coverage   89.21%   89.22%           
=======================================
  Files         662      662           
  Lines      191968   191968           
  Branches    36955    36955           
=======================================
+ Hits       171269   171276    +7     
- Misses      13535    13542    +7     
+ Partials     7164     7150   -14     
Files with missing lines Coverage Δ
src/inspector/worker_inspector.h 100.00% <ø> (ø)

... and 43 files with indirect coverage changes

@tjuhaszrh tjuhaszrh changed the title src: Adding #include <cstdint> to worker_inspector. h for gcc v15 src: adding #include <cstdint> to worker_inspector. h for gcc v15 Jan 24, 2025
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 merged commit bade7a1 into nodejs:main Jan 25, 2025
77 of 78 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Jan 25, 2025

Landed in bade7a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lts-watch-v20.x PRs that may need to be released in v20.x needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails with gcc v15 - uint64_t undefined
6 participants