test: convert test_encoding_binding.cc to a JS test #56791
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
|
@anonrig @jasnell @lemire @RafaelGSS Requesting original reviewer to review if the converted test is valid. The original cctest tests "invalid latin1" and expects an exception thrown. But there is no "invalid latin1" characters. |
legendecas
force-pushed
the
cctest-scan-files
branch
from
f31274d to
07a1f22
Compare
legendecas
changed the title
anonrig
approved these changes
Jan 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56791 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 663 663
Lines 192002 192002
Branches 36928 36931 +3
=======================================
+ Hits 171292 171294 +2
+ Misses 13583 13569 -14
- Partials 7127 7139 +12 |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
legendecas
force-pushed
the
cctest-scan-files
branch
from
58ad552 to
d4de8b6
Compare
richardlau
approved these changes
Jan 28, 2025
jasnell
approved these changes
Jan 28, 2025
targos
added
the
commit-queue
legendecas
added
the
commit-queue-rebase
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56791 ✔ Done loading data for nodejs/node/pull/56791 ----------------------------------- PR info ------------------------------------ Title test: convert test_encoding_binding.cc to a JS test (#56791) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:cctest-scan-files -> nodejs:main Labels build, needs-ci, commit-queue-rebase Commits 3 - test: convert test_encoding_binding.cc to a JS test - test: search cctest files - fixup! test: search cctest files Committers 1 - Chengzhong Wu <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56791 Refs: https://github.com/nodejs/node/pull/55275 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56791 Refs: https://github.com/nodejs/node/pull/55275 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 27 Jan 2025 15:44:01 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/56791#pullrequestreview-2575833947 ✔ - Daniel Lemire (@lemire): https://github.com/nodejs/node/pull/56791#pullrequestreview-2575840776 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/56791#pullrequestreview-2578108349 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56791#pullrequestreview-2578763757 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-01-28T10:44:43Z: https://ci.nodejs.org/job/node-test-pull-request/64794/ - Querying data for job/node-test-pull-request/64794/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13035060751 |
The cctest file `test_encoding_binding.cc` is never tested and it is not a valid test. Binding functions should never be tested with V8 API circumvented. A binding function should only be tested with JS calls.
To prevent a new cctest missing from the `node.gyp`, search cctest files with tool `search_files.py` at configure time.
legendecas
force-pushed
the
cctest-scan-files
branch
from
d4de8b6 to
c639e65
Compare
|
Rebased to address conflicts. |
legendecas
added
request-ci
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Jan 29, 2025
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1b2a966...82ac335 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
The cctest file `test_encoding_binding.cc` is never tested and it is not a valid test. Binding functions should never be tested with V8 API circumvented. A binding function should only be tested with JS calls. PR-URL: #56791 Refs: #55275 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
To prevent a new cctest missing from the `node.gyp`, search cctest files with tool `search_files.py` at configure time. PR-URL: #56791 Refs: #55275 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Jan 30, 2025
Handle cases where the path the the Python executable contains spaces. Refs: nodejs#56791
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Jan 30, 2025
Handle cases where the path to the Python executable contains spaces. Refs: nodejs#56791
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
Handle cases where the path to the Python executable contains spaces. Refs: #56791 PR-URL: #56826 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 2, 2025
The cctest file `test_encoding_binding.cc` is never tested and it is not a valid test. Binding functions should never be tested with V8 API circumvented. A binding function should only be tested with JS calls. PR-URL: #56791 Refs: #55275 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 2, 2025
To prevent a new cctest missing from the `node.gyp`, search cctest files with tool `search_files.py` at configure time. PR-URL: #56791 Refs: #55275 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 2, 2025
Handle cases where the path to the Python executable contains spaces. Refs: #56791 PR-URL: #56826 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: convert test_encoding_binding.cc to a JS test
The cctest file
test_encoding_binding.ccis never tested and it isnot a valid test. Binding functions should not be tested with V8 API
circumvented. A binding function should only be tested with JS calls.
test: search cctest files
To prevent a new cctest missing from the
node.gyp, search cctestfiles with tool
search_files.pyat configure time.Refs: #55275