Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: run macOS test workflow with Xcode 16.1 #56831

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

targos
Copy link
Member

@targos targos commented Jan 30, 2025

We have to remove macos-13 as it doesn't have Xcode 16 available.

Refs: #56824

We have to remove `macos-13` as it doesn't have Xcode 16 available.

Refs: nodejs#56824
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 30, 2025
@targos
Copy link
Member Author

targos commented Jan 30, 2025

Not sure why the workflow doesn't run. Took some time to start.

@richardlau
Copy link
Member

Not sure why the workflow doesn't run. Took some time to start.

Most likely linked to the GitHub caching issues around the same time: https://www.githubstatus.com/incidents/nm83zrdky73y.

@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 30, 2025
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2025
@nodejs-github-bot nodejs-github-bot merged commit f05d287 into nodejs:main Jan 31, 2025
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f05d287

targos added a commit that referenced this pull request Feb 2, 2025
We have to remove `macos-13` as it doesn't have Xcode 16 available.

Refs: #56824
PR-URL: #56831
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants