-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "src: modernize cleanup queue to use c++20" #56846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 581b444.
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
labels
Jan 31, 2025
richardlau
added
request-ci
Add this label to start a Jenkins CI on a PR.
fast-track
PRs that do not need to wait for 48 hours to land.
labels
Jan 31, 2025
Fast-track has been requested by @richardlau. Please 👍 to approve. |
lpinca
approved these changes
Jan 31, 2025
cjihrig
approved these changes
Jan 31, 2025
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 31, 2025
This comment was marked as outdated.
This comment was marked as outdated.
targos
approved these changes
Jan 31, 2025
anonrig
approved these changes
Jan 31, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56846 +/- ##
==========================================
+ Coverage 88.70% 89.20% +0.50%
==========================================
Files 663 663
Lines 192012 192012
Branches 36613 36933 +320
==========================================
+ Hits 170317 171287 +970
+ Misses 14520 13609 -911
+ Partials 7175 7116 -59
|
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jan 31, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
targos
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 1, 2025
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Feb 1, 2025
Landed in ad84558 |
aduh95
added
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v23.x
PRs that should not land on the v23.x-staging branch and should not be released in v23.x.
labels
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
dont-land-on-v18.x
PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
dont-land-on-v22.x
PRs that should not land on the v22.x-staging branch and should not be released in v22.x.
dont-land-on-v23.x
PRs that should not land on the v23.x-staging branch and should not be released in v23.x.
fast-track
PRs that do not need to wait for 48 hours to land.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 581b444.
Refs: #56063
Fixes failing Test Linux workflow.