Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

querystring: fix comments #6365

Merged
merged 1 commit into from
Apr 25, 2016
Merged

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Apr 25, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • querystring
Description of change

Fixes a couple of comments.

@mscdex mscdex added the querystring Issues and PRs related to the built-in querystring module. label Apr 25, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Apr 25, 2016

LGTM

2 similar comments
@targos
Copy link
Member

targos commented Apr 25, 2016

LGTM

@evanlucas
Copy link
Contributor

LGTM

PR-URL: nodejs#6365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@mscdex mscdex force-pushed the querystring-fix-comments branch 2 times, most recently from d877f6a to d5922bd Compare April 25, 2016 13:58
@mscdex mscdex merged commit d5922bd into nodejs:master Apr 25, 2016
@mscdex mscdex deleted the querystring-fix-comments branch April 25, 2016 14:23
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
PR-URL: nodejs#6365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
PR-URL: #6365
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@MylesBorins
Copy link
Contributor

setting as don't land for right now

@mscdex let me know if this was incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
querystring Issues and PRs related to the built-in querystring module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants