dns: handle array holes in setServers() #8567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjihrig any objections for landing this? |
|
I was waiting for the CI to clear up to get a better run. Feel free to land it. Otherwise, I'll try to get to it this evening. |
|
|
|
Is this semver-minor or semver-patch? |
|
@ChALkeR should I stop landing? Was about to push when you posted your comment. |
|
Since I think we usually equate failing |
This commit adds better handling of exceptional array formats passed to dns.setServers(). Prior to this commit, the input array was validated using map(), which preserves holes, allowing them to be passed to c-ares, crashing Node. This commit replaces map() with forEach(), which skips holes. Fixes: nodejs#8538 PR-URL: nodejs#8567 Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
the original test does not dump core on v4.x @cjihrig let me know if this should be backported, labeling as don't land for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
dns
Description of change
This commit adds better handling of exceptional array formats passed to
dns.setServers(). Prior to this commit, the input array was validated usingmap(), which preserves holes, allowing them to be passed to c-ares, crashing Node. This commit replacesmap()withforEach(), which skips holes.Tests taken from #8538. Fixes #8538