Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

feat: 🎸 Added search feature to /learn #2233

Closed
wants to merge 2 commits into from
Closed

feat: 🎸 Added search feature to /learn #2233

wants to merge 2 commits into from

Conversation

benhalverson
Copy link
Member

Description

reimplementing the search feature

Related Issues

#1677

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Jan 27, 2022
@github-actions github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Jan 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022 •
edited
Loading

Codecov Report

Merging #2233 (5e98be1) into main (ecd3930) will decrease coverage by 1.69%.
The diff coverage is 53.48%.

@@            Coverage Diff             @@
##             main    #2233      +/-   ##
==========================================
- Coverage   91.54%   89.85%   -1.70%     
==========================================
  Files          85       87       +2     
  Lines         923      966      +43     
  Branches      249      265      +16     
==========================================
+ Hits          845      868      +23     
- Misses         78       98      +20
Impacted Files Coverage Δ
src/components/SearchBar/index.tsx 33.33% <33.33%> (ø)
src/components/SearchBar/SearchInput.tsx 52.77% <52.77%> (ø)
src/components/Header/index.tsx 95.23% <75.00%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd3930...5e98be1. Read the comment docs.

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Jan 27, 2022
@github-actions github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Jan 27, 2022
@github-actions
Copy link

Please find a preview at: https://staging.nodejs.dev/2233/

@benhalverson
Copy link
Member Author

switching to a draft because i'm seeing an error in production that doesnt show in the dev env.

mikeesto
mikeesto reviewed Jan 28, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
mikeesto
mikeesto reviewed Jan 28, 2022
View reviewed changes
gatsby-config.js Outdated Show resolved Hide resolved
@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Jan 28, 2022
@github-actions github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Jan 28, 2022
@github-actions
Copy link

Please find a preview at: https://staging.nodejs.dev/2233/

@mikeesto
Copy link
Member

LGTM now, nice one 👍

It would be cool if ESC closed the dropdown, and on some viewports the sizing is a little awkward but those are definitely nits for the future

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Feb 26, 2022
@github-actions github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Feb 26, 2022
@github-actions
Copy link

Please find a preview at: https://staging.nodejs.dev/2233/

@benhalverson
feat: 🎸 Added search feature to /learn
1a7ba9a 
reimplementing the search feature

feat: 🎸 added missing packages

changed engineOptions

feat: 🎸 Added search feature to /learn

reimplementing the search feature

feat: 🎸 added missing packages

changed engineOptions
@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label May 8, 2022
@github-actions github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label May 8, 2022
@github-actions
Copy link

github-actions bot commented May 8, 2022

Please find a preview at: https://staging.nodejs.dev/2233/

@benhalverson
Copy link
Member Author

superseded by #2502

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikeesto mikeesto mikeesto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benhalverson @codecov-commenter @mikeesto