feat: replace relative import closes #5484 #5487

umairraza96 · 2023-07-09T12:13:01Z

Description

Added a plugin for eslint eslint-plugin-no-relative-import-paths

Related Issues

Check List

I have read the Contributing Guidelines and made commit messages that follow the guideline.
I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
I have run npx turbo format to ensure the code follows the style guide.
I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
I've covered new added functionality with unit tests if necessary.

vercel · 2023-07-09T12:13:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 12, 2023 10:03pm
nodejs-org-stories	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 12, 2023 10:03pm

mikeesto

Thanks for the PR. I think this on the right track but these changes have broken storybook. Can you please have a look at this: https://github.com/nodejs/nodejs.org/actions/runs/5499772573/jobs/10027807119?pr=5487

umairraza96 · 2023-07-10T14:30:05Z

Thanks for the PR. I think this on the right track but these changes have broken storybook. Can you please have a look at this: https://github.com/nodejs/nodejs.org/actions/runs/5499772573/jobs/10027807119?pr=5487

I have fixed the test issue but there is 1 snapshot test that is failing and I don't know whats causing it may be we need to record a new snapshot need assistance on this

ovflowd · 2023-07-10T14:31:34Z

Thanks for the PR. I think this on the right track but these changes have broken storybook. Can you please have a look at this: nodejs/nodejs.org/actions/runs/5499772573/jobs/10027807119?pr=5487

I have fixed the test issue but there is 1 snapshot test that is failing and I don't know whats causing it may be we need to record a new snapshot need assistance on this

Can you first rebase your branch? We did a few changes on some files that are conflicting.

Now, to update the snapshots you can simply run npm run test:storybook:snapshot

github-actions · 2023-07-10T21:39:35Z

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

ovflowd · 2023-07-12T21:15:30Z

FYI rebasing seems to be needed!

Signed-off-by: Umair Raza <[email protected]>

Used below command to revert back to the `build-and-analysis.yml` file ```bash git checkout main -- .github/workflows/build-and-analysis.yml ```

ovflowd · 2023-07-13T14:51:58Z

@umairraza96 could we do the rebasing or recreation once more? And then I'll prioritise getting this merged so that you don't need to worry about further rebases/updates! 🙇

ovflowd · 2023-07-13T14:52:22Z

.github/workflows/build-and-analysis.yml

@@ -46,7 +46,7 @@ jobs:
            ~/.npm
            .next/cache
            node_modules/.cache
-          key: cache-${{ hashFiles('package-lock.json') }}


Unrelated changes again over here :S

ovflowd · 2023-07-13T14:52:37Z

public/node-releases-data.json

@@ -1 +1 @@
-[]


Also unrelated changes here

Why we don’t put this file in gitinignore ?

This was already discussed before. And the file should not be on gitignore. (Also adding it right now would have 0 effects)

umairraza96 · 2023-07-13T22:46:46Z

@ovflowd I created a new branch #5513 which closes #5487

ovflowd · 2023-07-13T22:48:27Z

I see, you could simply have deleted this one, rebranch from main and force push, so that you wouldn’t need to create a new PR 🙈

But that’s okay, let’s close this one!

mikeesto · 2023-07-14T02:33:32Z

Closing in favor of #5513

umairraza96 requested a review from a team as a code owner July 9, 2023 12:13

vercel bot temporarily deployed to Preview – nodejs-org July 9, 2023 12:14 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories July 9, 2023 12:14 Inactive

mikeesto reviewed Jul 10, 2023

View reviewed changes

vercel bot temporarily deployed to Preview – nodejs-org July 10, 2023 14:28 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories July 10, 2023 14:29 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories July 10, 2023 14:41 Inactive

vercel bot temporarily deployed to Preview – nodejs-org July 10, 2023 14:42 Inactive

vercel bot temporarily deployed to Preview – nodejs-org July 10, 2023 21:39 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories July 10, 2023 21:39 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories July 10, 2023 22:07 Inactive

vercel bot temporarily deployed to Preview – nodejs-org July 10, 2023 22:07 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories July 10, 2023 22:31 Inactive

vercel bot temporarily deployed to Preview – nodejs-org July 10, 2023 22:32 Inactive

umairraza96 and others added 12 commits July 11, 2023 03:37

feat: replace relative import closes nodejs#5484

d966472

fix: storybook tests

90cc241

fix: fixing types

3654b5e

chore: use defined urls for distribution and api docs (nodejs#5494)

ccbc7e1

feat: replace relative import closes nodejs#5484

8bb3dc0

chore: use defined urls for distribution and api docs (nodejs#5494)

01c7416

feat: replace relative import closes nodejs#5484

9a8c26c

fix: dupicates in some components

6573298

chore: use defined urls for distribution and api docs (nodejs#5494)

44ca88e

chore: attempt to create a bundle analysis file (nodejs#5489)

5b20e19

chore: dedicated step for build and analysis (nodejs#5496)

f4b920a

chore: use defined urls for distribution and api docs (nodejs#5494)

4586396

umairraza96 added 3 commits July 13, 2023 02:13

feat: replace relative import closes nodejs#5484

e0389be

fix: diff in generated files

8da5639

fix: map directory with alias instead of hard code

0fada61

vercel bot temporarily deployed to Preview – nodejs-org-stories July 12, 2023 21:14 Inactive

vercel bot temporarily deployed to Preview – nodejs-org July 12, 2023 21:14 Inactive

Merge branch 'main' into feat/relative-imports

c6c06d7

Signed-off-by: Umair Raza <[email protected]>

vercel bot temporarily deployed to Preview – nodejs-org-stories July 12, 2023 21:20 Inactive

vercel bot temporarily deployed to Preview – nodejs-org July 12, 2023 21:20 Inactive

ovflowd and others added 8 commits July 13, 2023 02:56

chore: use defined urls for distribution and api docs (nodejs#5494)

2d315c0

chore: use defined urls for distribution and api docs (nodejs#5494)

abc9d66

chore: use defined urls for distribution and api docs (nodejs#5494)

32a6ee6

fix: dupicates in some components

7ea92d2

chore: use defined urls for distribution and api docs (nodejs#5494)

7486478

fix: diff in generated files

d45e4eb

feat: replace relative import closes nodejs#5484

c241043

fix: diff in generated files

28dc8ad

vercel bot temporarily deployed to Preview – nodejs-org-stories July 12, 2023 21:58 Inactive

vercel bot temporarily deployed to Preview – nodejs-org July 12, 2023 21:59 Inactive

fix: change back the build-and-analysis.yml

56e7951

Used below command to revert back to the `build-and-analysis.yml` file ```bash git checkout main -- .github/workflows/build-and-analysis.yml ```

vercel bot temporarily deployed to Preview – nodejs-org July 12, 2023 22:03 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories July 12, 2023 22:03 Inactive

ovflowd reviewed Jul 13, 2023

View reviewed changes

mikeesto closed this Jul 14, 2023

umairraza96 deleted the feat/relative-imports branch July 21, 2023 16:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: replace relative import closes #5484 #5487

feat: replace relative import closes #5484 #5487

umairraza96 commented Jul 9, 2023 •

edited

Loading

vercel bot commented Jul 9, 2023 •

edited

Loading

mikeesto left a comment

umairraza96 commented Jul 10, 2023

ovflowd commented Jul 10, 2023

github-actions bot commented Jul 10, 2023 •

edited

Loading

ovflowd commented Jul 12, 2023

ovflowd commented Jul 13, 2023

ovflowd Jul 13, 2023

ovflowd Jul 13, 2023

AugustinMauroy Jul 13, 2023

ovflowd Jul 13, 2023

umairraza96 commented Jul 13, 2023 •

edited

Loading

ovflowd commented Jul 13, 2023

mikeesto commented Jul 14, 2023

feat: replace relative import closes #5484 #5487

feat: replace relative import closes #5484 #5487

Conversation

umairraza96 commented Jul 9, 2023 • edited Loading

Description

Related Issues

Check List

vercel bot commented Jul 9, 2023 • edited Loading

mikeesto left a comment

Choose a reason for hiding this comment

umairraza96 commented Jul 10, 2023

ovflowd commented Jul 10, 2023

github-actions bot commented Jul 10, 2023 • edited Loading

📦 Next.js Bundle Analysis for nodejs.org

ovflowd commented Jul 12, 2023

ovflowd commented Jul 13, 2023

ovflowd Jul 13, 2023

Choose a reason for hiding this comment

ovflowd Jul 13, 2023

Choose a reason for hiding this comment

AugustinMauroy Jul 13, 2023

Choose a reason for hiding this comment

ovflowd Jul 13, 2023

Choose a reason for hiding this comment

umairraza96 commented Jul 13, 2023 • edited Loading

ovflowd commented Jul 13, 2023

mikeesto commented Jul 14, 2023

umairraza96 commented Jul 9, 2023 •

edited

Loading

vercel bot commented Jul 9, 2023 •

edited

Loading

github-actions bot commented Jul 10, 2023 •

edited

Loading

umairraza96 commented Jul 13, 2023 •

edited

Loading