Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationship to private security activities #2

Closed
wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Nov 29, 2016

Proposed relationship and wording for that relationship. Comments?

/cc @nodejs/security

@indutny
Copy link
Member

indutny commented Nov 29, 2016

👍

@jasnell
Copy link
Member

jasnell commented Nov 29, 2016

LGTM

@Trott
Copy link
Member

Trott commented Nov 29, 2016

Is there concern that people won't read that and assume that this repo is where they should report security issues? Might there be a better name for the repo/wg?

@Trott
Copy link
Member

Trott commented Nov 29, 2016

I should clarify that my questions above are not objections. This can totally land if it's all LGTMs and stuff. If anyone does want to consider a different name, perhaps something like "security policy wg" might be slightly better than just "security wg" even if it doesn't cover everything the wg will do.

@jbergstroem
Copy link
Member

I think Rich has a good point. If the first line is "dont report security issues here" the naming could probably be improved. Never the less, wording is LGTM.

@rvagg rvagg mentioned this pull request Nov 30, 2016
@mhdawson
Copy link
Member

LGTM with rename to "Security policy wg"

@sam-github
Copy link
Contributor

This is landable, but I don't have access rights to do so. I annotated with the landing meta-data: https://github.com/sam-github/security-wg/commit/91f263c3a3d8a5a86d0e66a61fe9bba9b552b131 @rvagg can you land?

sam-github pushed a commit that referenced this pull request Jan 5, 2017
PR-URL: #2
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@sam-github
Copy link
Contributor

Landed in 28ae71a

@sam-github sam-github closed this Jan 5, 2017
@sam-github sam-github deleted the private-security-overlap branch January 5, 2017 19:35
patrickm68 added a commit to patrickm68/security-wg-process that referenced this pull request Sep 14, 2023
PR-URL: nodejs/security-wg#2
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
mattstern31 added a commit to mattstern31/security-wg-process that referenced this pull request Nov 11, 2023
PR-URL: nodejs/security-wg#2
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants