-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fetch): prevent Illegal invocations
of the FileLike
class
#1207
fix(fetch): prevent Illegal invocations
of the FileLike
class
#1207
Conversation
Signed-off-by: Darshan Sen <[email protected]>
FileLike
classIllegal invocations
of the FileLike
class
Codecov Report
@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 93.78% 93.50% -0.28%
==========================================
Files 43 43
Lines 4021 4035 +14
==========================================
+ Hits 3771 3773 +2
- Misses 250 262 +12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Is it part of the spec?
I added the validators because the rest of the methods both in
Is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Darshan Sen [email protected]