-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: capture error stack traces #1619
Conversation
@mcollina Please review 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, looks like something broke in the tests @mcollina any clues as to why this fails on node 14? my guess is that I am testing What's the difference between |
@sidwebworks move the test file to the test/fetch folder |
Codecov Report
@@ Coverage Diff @@
## main #1619 +/- ##
=======================================
Coverage 94.92% 94.93%
=======================================
Files 50 50
Lines 4792 4798 +6
=======================================
+ Hits 4549 4555 +6
Misses 243 243
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@KhafraDev Thank you for the help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Resolves: #1599
Checklist: