Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit with 1 if WPT runner has unexpected errors #2621

Merged
merged 5 commits into from
Jan 16, 2024
Merged

exit with 1 if WPT runner has unexpected errors #2621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8860eab
exit with 1 if WPT runner has unexpected errors
KhafraDev Jan 16, 2024
1fefd8b
fixup
KhafraDev Jan 16, 2024
c9cf419
fixup
KhafraDev Jan 16, 2024
0996731
fixup
KhafraDev Jan 16, 2024
ddaff06
Update test/wpt/runner/runner.mjs
KhafraDev Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/wpt/runner/runner.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ export class WPTRunner extends EventEmitter {
`skipped: ${skipped}`
)

process.exit(0)
process.exit(failed - expectedFailures ? 1 : process.exitCode)
}

addInitScript (code) {
Expand Down
9 changes: 9 additions & 0 deletions test/wpt/runner/worker.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { WebSocket } from '../../../lib/websocket/websocket.js'
import { Cache } from '../../../lib/cache/cache.js'
import { CacheStorage } from '../../../lib/cache/cachestorage.js'
import { kConstruct } from '../../../lib/cache/symbols.js'
import { webcrypto } from 'node:crypto'

const { initScripts, meta, test, url, path } = workerData

Expand Down Expand Up @@ -92,6 +93,14 @@ Object.defineProperties(globalThis, {
}
})

// TODO: remove once node 18 is dropped
if (!globalThis.crypto) {
Object.defineProperty(globalThis, 'crypto', {
...globalPropertyDescriptors,
value: webcrypto
})
}

// self is required by testharness
// GLOBAL is required by self
runInThisContext(`
Expand Down
13 changes: 12 additions & 1 deletion test/wpt/status/fetch.status.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,14 @@
"skip": true
},
"scheme-blob.sub.any.js": {
"note": "fails everywhere",
"note": "fail: fails everywhere, flaky: only node 18",
"fail": [
"Fetching URL.createObjectURL(invalid_type_blob) is OK"
],
"flaky": [
"Fetching URL.createObjectURL(empty_blob) is OK",
"Fetching URL.createObjectURL(empty_type_blob) is OK",
"Fetching URL.createObjectURL(empty_data_blob) is OK"
]
},
"status.h2.any.js": {
Expand Down Expand Up @@ -417,6 +422,12 @@
"note": "this is a bug in webstreams, see https://github.com/nodejs/node/issues/46786",
"skip": true
}
},
"idlharness.any.js": {
"note": "https://github.com/nodejs/undici/issues/1666#issuecomment-1275177704",
"fail": [
"Window interface: operation fetch(RequestInfo, optional RequestInit)"
]
}
},
"content-length": {
Expand Down
Loading