refactor(#2722)!: Drop Interceptors support

[metcoder95]

This relates to...

#2722

Rationale

Drop support for interceptors feature.

• Re-Implement Redirect instead of Interceptor
• Document the recommended chaining approach

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

• I have read and agreed to the Developer's Certificate of Origin
• Tested
• Benchmarked (optional)
• Documented
• Review ready
• In review
• Merge ready

[metcoder95]

We need to rebase main on top of next; I'll try to do that later Today

[ronag]

Nice! I think you need to do a rebase.

[ronag]

@metcoder95 I really appreciate your contributions with this. I'm passionate about these changes but overwhelmed with my current workload.

[metcoder95]

Nice! I think you need to do a rebase.

Its next already up-to-date with main?

@metcoder95 I really appreciate your contributions with this. I'm passionate about these changes but overwhelmed with my current workload.

Happy to help! This cleanup is looking great, happy to help preparing next undici major 🚀

[ronag]

I would prefer to move this one level higher to the api methods, i.e. totally exclude from normal dispatch

[metcoder95]

So basically just expose it but not add it directly; then several tests will be affected, I’ll go over them during the weekend then 👍

I’ll split this into two PRs, one to remove all sign of interceptors, and a second one to expose Redirect handler and others in a different way.

[ronag]

You don't actually need to break so many tests if you just move it into the api methods (stream, pipeline and request).

[metcoder95]

Ah, ok, I didn't get that first; so instead of keeping it at a low level, you suggest adding it to the APIs instead; if I understood correctly, sure 👍

[ronag]

Suggested change

	return dispatcher.dispatch(
	opts,
	new RedirectHandler(
	dispatcher.dispatch.bind(dispatcher),
	this[kMaxRedirections],
	opts,
	handler
	)
	)
	throw new Error('maxRedirection no longer directly supported on Agent')

[ronag]

You can add something like:

// api/api-request.js

function request (opts, callback) {
  if (callback === undefined) {
    return new Promise((resolve, reject) => {
      request.call(this, opts, (err, data) => {
        return err ? reject(err) : resolve(data)
      })
    })
  }

  let maxRedirections = opts?.maxRedirections ?? 0
  if (!Number.isInteger(maxRedirections) || maxRedirections < 0) {
    throw new InvalidArgumentError('maxRedirections must be a positive number')
  }

  let dispatch = (opts, handler) => this.dispatch(opts, handler)
  if (maxRedirections > 0) {
    dispatch = (opts, handler) => dispatch(opts, new RedirectHandler(dispatch, maxRedirections, opts, handler))
  }
    
  try {
    dispatch(opts, new RequestHandler(opts, callback))
  } catch (err) {
    if (typeof callback !== 'function') {
      throw err
    }
    const opaque = opts?.opaque
    queueMicrotask(() => callback(err, { opaque }))
  }
}

[Uzlopak]

@mikicho

Is this relevant for your interceptors project?

[mikicho]

@Uzlopak We currently don't support undici directly. Only fetch which uses undici under the hood.