Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix nightly workflow #3525

Merged
merged 1 commit into from
Aug 30, 2024
+0 −1
Merged

ci: fix nightly workflow #3525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/autobahn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ on:
- 'test/autobahn/**'
permissions:
contents: read
pull-requests: write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this fix the nightly workflow?

I think we should just skip autobahn for nightly instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed pull-requests write permission when we created a comment in the PR. This was unreliable. So we removed the comment creation but did not remove the permission. Now in a scheduled run, where we call this workflow as reusable workflow, it can not have more perissions than the calling workflow.

We should not skip the autobahn tests. If we had them in the first place, we would have seen the issues with the regressions in node core regarding buffers earlier.


jobs:
autobahn:
Expand Down
Loading