Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run .mjs in test. Add npm test to CI. #511

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Jan 7, 2021

@mcollina mcollina requested a review from ronag January 7, 2021 17:28
@mcollina
Copy link
Member Author

mcollina commented Jan 7, 2021

This was spuriously introduced in #375, making our CITGM integration moot.

@Ethan-Arrowood please confirm this is not going to break anything for typescript.

@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #511 (41dfa45) into master (5e51cc4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #511   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          15       15           
  Lines        1274     1274           
=======================================
  Hits         1269     1269           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e51cc4...41dfa45. Read the comment docs.

@Ethan-Arrowood
Copy link
Collaborator

Oh huh i wonder why I made that change. No that shouldn't break TS. Maybe that trickled through an invalid rebase or something.

@Ethan-Arrowood
Copy link
Collaborator

looks like one CI timed out but its push equivalent run passed.

@mcollina mcollina merged commit bd15242 into master Jan 11, 2021
@Uzlopak Uzlopak deleted the fix-test-script branch February 21, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants