Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get and set event #11

Merged
merged 2 commits into from
May 10, 2017
Merged

get and set event #11

merged 2 commits into from
May 10, 2017

Conversation

malash
Copy link
Member

@malash malash commented May 9, 2017 •
edited
Loading

Non-breaking changes

legacy event new event desc
change set state.set() called
- get state.get() called
update change in v1 if is(newState, oldState) === false after change emit
  1. New events name as above. Legacy events are still supported.
  2. get event for partial @connect in @noflux/react.

@malash malash requested review from ssnau and sartrey May 9, 2017 14:34
@ssnau
Copy link
Contributor

ssnau commented May 9, 2017

LGTM

@malash malash merged commit fe2b7ed into next May 10, 2017
@malash malash deleted the next-event branch May 10, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssnau ssnau Awaiting requested review from ssnau

@sartrey sartrey Awaiting requested review from sartrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malash @ssnau