Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash on mac #51

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Prevent crash on mac #51

merged 1 commit into from
Mar 27, 2024

Conversation

shiena
Copy link
Contributor

@shiena shiena commented Mar 27, 2024

fixed #50

Prevent crashes during window resizing on mac.
Because the value_changed is called many times in one SpinBox button click on mac.

The godot4 branch is fine as is.

@noidexe noidexe merged commit 55c907a into noidexe:main Mar 27, 2024
@noidexe
Copy link
Owner

noidexe commented Mar 27, 2024

Merged. Thank you. Still think it's something that should be reported. The behavior should be the same on all platforms

@shiena shiena deleted the fix/crash_on_mac branch March 27, 2024 17:56
@shiena
Copy link
Contributor Author

shiena commented Mar 28, 2024

@noidexe
I built the engine from source from the 3.x branch of godot and then built godot-version-manager. Then the SpinBox button worked correctly with the source before this pull request was incorporated. So I think the problem will be fixed in the next series 3 release.

@noidexe
Copy link
Owner

noidexe commented Mar 28, 2024

Awesome. Thank you for taking all the effort to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on macos, clicking "down" on the UI scale feature will crash the application
2 participants