Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Just use first circuit report in gates diff test #1

Merged
merged 8 commits into from
Apr 5, 2024

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Apr 4, 2024

No description provided.

vezenovm added 7 commits April 4, 2024 20:51

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…ter gate report wwill fail with these changes

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vezenovm
Copy link
Contributor Author

vezenovm commented Apr 5, 2024

@TomAFrench this now passes on noir-lang/noir#4719. I was thinking we could merge this PR, I switch to using a commit on the main branch, then make a follow-up on Noir and here that switches back to using loadReports instead of loadOldReports for the reference content.

@TomAFrench
Copy link
Member

Yep, looks like a good plan to me.

@TomAFrench TomAFrench merged commit 8658815 into noir-lang:main Apr 5, 2024
TomAFrench pushed a commit that referenced this pull request Apr 25, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Temp check using same content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants