fix: don't crash on broken impl syntax (#7512)

noir-lang · Feb 25, 2025 · 677c10c · 677c10c
1 parent 6f78848
commit 677c10c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/compiler/noirc_frontend/src/elaborator/mod.rs b/compiler/noirc_frontend/src/elaborator/mod.rs
@@ -2134,7 +2134,7 @@ impl<'context> Elaborator<'context> {
                     let span = location.span;
                     let found = trait_impl.r#trait.typ.to_string();
                     self.push_err(ResolverError::ExpectedTrait { span, found }, location.file);
-                    continue;
+                    (None, GenericTypeArgs::default(), location)
                 }
             };
 

diff --git a/test_programs/compile_failure/broken_impl/Nargo.toml b/test_programs/compile_failure/broken_impl/Nargo.toml
@@ -0,0 +1,7 @@
+[package]
+name = "broken_impl"
+type = "bin"
+authors = [""]
+compiler_version = ">=0.26.0"
+
+[dependencies]
diff --git a/test_programs/compile_failure/broken_impl/src/main.nr b/test_programs/compile_failure/broken_impl/src/main.nr
@@ -0,0 +1,2 @@
+// This used to crash the compiler
+impl< Foo for
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		// This used to crash the compiler
		impl< Foo for