feat: Sync from aztec-packages (#7474)

Co-authored-by: Tom French <[email protected]>

.aztec-sync-commit

@@ -1 +1 @@
-b60a39d989b77702a89ebb24047e5b2419915dc3
+f7a65ee697aa7e1a2bbdfcafe9d846aadd9aa2c2

.github/workflows/pull-request-title.yml

@@ -31,10 +31,10 @@ jobs:
   force-push-comment:
     name: Warn external contributors about force-pushing
     runs-on: ubuntu-22.04
-    if: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != 'noir-lang/noir' }} 
+    if: ${{ github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != 'noir-lang/noir' }}
     permissions:
       pull-requests: write
-    
+
     steps:
       - name: Post comment on force pushes
         uses: marocchino/sticky-pull-request-comment@v2
@@ -45,4 +45,3 @@ jobs:
             Please **do not force push to this branch** after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.
 
             Thanks for your understanding.
-          

.github/workflows/reports.yml

@@ -115,10 +115,10 @@ jobs:
 
           ./gates_report_brillig.sh 9223372036854775807
           jq '.programs |= map(.package_name |= (. + "_inliner_max"))' gates_report_brillig.json > ./reports/gates_report_brillig_inliner_max.json
-          
+
           ./gates_report_brillig.sh 0
           jq '.programs |= map(.package_name |= (. + "_inliner_zero"))' gates_report_brillig.json > ./reports/gates_report_brillig_inliner_zero.json
-          
+
           ./gates_report_brillig.sh -9223372036854775808
           jq '.programs |= map(.package_name |= (. + "_inliner_min"))' gates_report_brillig.json > ./reports/gates_report_brillig_inliner_min.json
 
@@ -160,14 +160,14 @@ jobs:
       - name: Generate Brillig execution report
         working-directory: ./test_programs
         run: |
-          mkdir ./reports 
-          
+          mkdir ./reports
+
           ./gates_report_brillig_execution.sh 9223372036854775807
           jq '.programs |= map(.package_name |= (. + "_inliner_max"))' gates_report_brillig_execution.json > ./reports/gates_report_brillig_execution_inliner_max.json
 
           ./gates_report_brillig_execution.sh 0
           jq '.programs |= map(.package_name |= (. + "_inliner_zero"))' gates_report_brillig_execution.json > ./reports/gates_report_brillig_execution_inliner_zero.json
-          
+
           ./gates_report_brillig_execution.sh -9223372036854775808
           jq '.programs |= map(.package_name |= (. + "_inliner_min"))' gates_report_brillig_execution.json > ./reports/gates_report_brillig_execution_inliner_min.json
 
@@ -258,15 +258,15 @@ jobs:
         run: |
           ./execution_report.sh 0 1
           mv execution_report.json ../execution_report.json
-          
+
       - name: Upload compilation report
         uses: actions/upload-artifact@v4
         with:
           name: in_progress_compilation_report
           path: compilation_report.json
           retention-days: 3
           overwrite: true
-      
+
       - name: Upload execution report
         uses: actions/upload-artifact@v4
         with:
@@ -413,7 +413,7 @@ jobs:
             test_programs/memory_report.sh
             test_programs/parse_memory.sh
           sparse-checkout-cone-mode: false
-      
+
       - name: Download nargo binary
         uses: ./scripts/.github/actions/download-nargo
 
@@ -503,10 +503,10 @@ jobs:
           fi
 
   upload_compilation_report:
-    name: Upload compilation report 
+    name: Upload compilation report
     needs: [generate_compilation_and_execution_report, external_repo_compilation_and_execution_report]
     # We want this job to run even if one variation of the matrix in `external_repo_compilation_and_execution_report` fails
-    if: always() 
+    if: always()
     runs-on: ubuntu-22.04
     permissions:
       pull-requests: write
@@ -554,10 +554,10 @@ jobs:
           max-items-in-chart: 50
 
   upload_compilation_memory_report:
-    name: Upload compilation memory report 
+    name: Upload compilation memory report
     needs: [generate_memory_report, external_repo_memory_report]
     # We want this job to run even if one variation of the matrix in `external_repo_memory_report` fails
-    if: always() 
+    if: always()
     runs-on: ubuntu-22.04
     permissions:
       pull-requests: write
@@ -604,10 +604,10 @@ jobs:
           max-items-in-chart: 50
 
   upload_execution_memory_report:
-    name: Upload execution memory report 
+    name: Upload execution memory report
     needs: [generate_memory_report, external_repo_memory_report]
     # We want this job to run even if one variation of the matrix in `external_repo_memory_report` fails
-    if: always() 
+    if: always()
     runs-on: ubuntu-22.04
     permissions:
       pull-requests: write
@@ -655,10 +655,10 @@ jobs:
 
 
   upload_execution_report:
-    name: Upload execution report 
+    name: Upload execution report
     needs: [generate_compilation_and_execution_report, external_repo_compilation_and_execution_report]
     # We want this job to run even if one variation of the matrix in `external_repo_compilation_and_execution_report` fails
-    if: always() 
+    if: always()
     runs-on: ubuntu-22.04
     permissions:
       pull-requests: write

.github/workflows/test-js-packages.yml

@@ -541,7 +541,6 @@ jobs:
           fi
         env:
           NARGO_IGNORE_TEST_FAILURES_FROM_FOREIGN_CALLS: true
-
       - name: Compare test results
         working-directory: ./noir-repo
         run: .github/scripts/check_test_results.sh .github/critical_libraries_status/${{ matrix.repo }}/${{ matrix.path }}.failures.jsonl .github/critical_libraries_status/${{ matrix.repo }}/${{ matrix.path }}.actual.jsonl
@@ -576,7 +575,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           path: noir-repo
-      
+
       - name: Checkout
         uses: actions/checkout@v4
         with:
@@ -595,13 +594,13 @@ jobs:
 
       - name: Run nargo compile
         working-directory: ./test-repo/noir-projects/noir-contracts
-        run: nargo compile --inliner-aggressiveness 0 
+        run: nargo compile --inliner-aggressiveness 0
 
   upload_critical_library_report:
-    name: Upload critical library report 
+    name: Upload critical library report
     needs: [external-repo-checks]
     # We want this job to run even if one variation of the matrix in `external-repo-checks` fails
-    if: always() 
+    if: always()
     runs-on: ubuntu-22.04
     permissions:
       pull-requests: write

.vscode/settings.json

@@ -8,5 +8,11 @@
     "[javascript]": {
         "editor.defaultFormatter": "esbenp.prettier-vscode"
     },
+    "[markdown]": {
+        "files.trimTrailingWhitespace": true
+    },
+    "[yaml]": {
+        "files.trimTrailingWhitespace": true
+    },
     "rust-analyzer.server.extraEnv": { "RUSTUP_TOOLCHAIN": "stable" }
 }